[#610] [Part 1] Update navigation library and refactor template to expose event callback to navigate #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…irectional data flow for sample compose
kaungkhantsoe
force-pushed
the
chore/610-part-1-update-navigation-library-and-refactor-to-follow-unidirectional-data-flow
branch
from
8f23608 to
d220269
Compare
kaungkhantsoe
temporarily deployed
to
template-compose
GitHub Actions
Inactive
Kover report for template-compose:🧛 Template - Compose Unit Tests Code Coverage:
|
| File | Coverage |
|---|---|
AppDestination.kt |
75.00% |
AppNavGraph.kt |
52.35% |
BaseViewModel.kt |
72.90% |
HomeScreen.kt |
67.89% |
HomeViewModel.kt |
100.00% |
MainDestination.kt |
60.00% |
MainNavGraph.kt |
37.50% |
Modified Files Not Found In Coverage Report:
BaseAppDestination.kt
HiltTestRunner.kt
HomeScreenTest.kt
HomeScreenTest.kt
HomeViewModelTest.kt
Item.kt
ItemList.kt
NavigationExt.kt
SecondScreen.kt
ThirdScreen.kt
build.gradle.kts
libs.versions.toml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#610
What happened 👀
Provide a description of the changes this pull request brings to the codebase. Additionally, when the pull request is still being worked on, a checklist of the planned changes is welcome to track progress.
Insight 📝
Describe in detail why this solution is the most appropriate, which solution you tried but did not go with, and how to test the changes. References to relevant documentation are welcome as well.
Proof Of Work 📹
Show us the implementation: screenshots, GIFs, etc.